Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration table filter and row collapse/expansion in guides #40524

Merged
merged 1 commit into from
May 11, 2024

Conversation

cknoblauch
Copy link
Contributor

This is a fix for the filter on top of the configuration reference tables in the guides.

The filter is currently failing because when the table is configured, it is attempted to remove a non-existing disabled attribute from the input field. The call fails (at least in my setup, FF 125 on Linux) which leaves the table and search fields in an inconsistent state; typing in the field does not filter and row collapse/expansion does not work.

@cknoblauch
Copy link
Contributor Author

This PR fixes a bug detected in the OpenTelemetry configuration reference, it may be present in other guides as well.

@geoand geoand requested a review from gsmet May 10, 2024 06:12
@gsmet
Copy link
Member

gsmet commented May 10, 2024

Thanks for taking the time to have a look at this and suggest a fix!

Copy link

quarkus-bot bot commented May 10, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b5af823.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented May 10, 2024

@cknoblauch how do you reproduce it? I was unable to get the behavior you described?

@cknoblauch
Copy link
Contributor Author

I stumbled upon this when I tried to filter the configuration properties on the OpenTelemetry guide. When the filter didn't work, I checked the JS console, found where it was failing and submitted the fix after testing it locally. Table row collapse/expansion was also broken before.

I checked again now and it happens only sometimes. I can always reproduce it with a hard reload and the Firefox JS debugger open; it's hit-or-miss otherwise. There may be some data that is cached across reloads.

@gsmet gsmet merged commit 2a218ea into quarkusio:main May 11, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 11, 2024
@gsmet
Copy link
Member

gsmet commented May 11, 2024

OK, I suspect a timing issue but let's get this in as better to not break. Thanks!

Copy link

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants