Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flyway & SQL Server native compilation #40552

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix Flyway & SQL Server native compilation #40552

merged 1 commit into from
May 10, 2024

Conversation

Vinche59
Copy link
Contributor

@Vinche59 Vinche59 commented May 10, 2024 •
edited by geoand
Loading

@Vinche59 @gsmet
Fix Flyway & SQL Server native compilation
09fa724 
Fix quarkusio#40551

Signed-off-by: Vinche <sourin-v@bridgestone-bae.com>
gsmet
gsmet approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the PR to drop the class entirely.

Thanks a lot for raising the issue and creating the PR. We will make sure it's in the next 3.10.

@gsmet gsmet changed the title Flyway & SQL Server native compilation Fix Flyway & SQL Server native compilation May 10, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 09fa724.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 48c7deb into quarkusio:main May 10, 2024
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 10, 2024
@gsmet gsmet modified the milestones: 3.11 - main, 3.10.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@gastaldi gastaldi gastaldi left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/flyway kind/bugfix
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

Quarkus 3.10 - Flyway with SQL Server DB failed to compile in native
4 participants
@Vinche59 @gastaldi @gsmet @geoand