Enable test which now works because of serialization changes #40749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
approved these changes
May 21, 2024
dmlloyd
added a commit
to dmlloyd/quarkus
that referenced
this pull request
May 21, 2024
Relates to quarkusio#40601, quarkusio#40749, quarkusio#38991. No use waiting for Dependabot. Fixes problem where an NPE can occur in some tests.
This comment has been minimized.
This comment has been minimized.
|
The failing tests are in my new test, so it looks like I need to be a bit more successful disabling it on native. Edit: Now fixed. |
holly-cummins
force-pushed
the
enable-test-which-now-works
branch
from
abb8e73
to
41474ac
Compare
holly-cummins
force-pushed
the
enable-test-which-now-works
branch
from
41474ac
to
b24844c
Compare
Status for workflow
|
gsmet
reviewed
May 22, 2024
| @@ -1,193 +0,0 @@ | |||
| # Log settings | |||
| # log level in lower case for testing | |||
| quarkus.log.level=info | |||
There was a problem hiding this comment.
Why is this file removed? It was useless?
There was a problem hiding this comment.
When I initially wrote these tests, I'd copied the files from another test. It had a whole bunch of settings that we didn't actually want in this test, such as setting the non-application-root to 1234. (Although, as mentioned above, even without the settings file, the non-application root is still 1234, which I haven't managed to explain.)
I left the file, so we had change history, but removed all of the settings since we didn't need any of them, as far as I know.
gsmet
approved these changes
May 22, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 29, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 29, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 30, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 30, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 30, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
May 30, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jun 27, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jun 28, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jun 29, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jun 30, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jul 1, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jul 1, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jul 31, 2024
holly-cummins
added a commit
to holly-cummins/quarkus
that referenced
this pull request
Jul 31, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
danielsoro
pushed a commit
to danielsoro/quarkus
that referenced
this pull request
Sep 20, 2024
danielsoro
pushed a commit
to danielsoro/quarkus
that referenced
this pull request
Sep 20, 2024
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35124 added several tests which could not pass, because of our test classloading issues. It's taken me a while (cough) to get on top of the code changes to make them pass, but @dmlloyd has fixed one category of them (and also quarkiverse/quarkus-pact#73) with #40601.
Because the test has been disabled for a while, it rotted slightly and got broken by some dev ui changes. The
DevUIJsonRPCTestwas seeing a non-defaultquarkus.http.non-application-root-path, so things failed. I can’t see where the problem value is coming from; perhaps some sticky config changes from a previous test? Cross-talk between tests is bad, but I didn’t want to get sucked into a config rabbit hole, so I just set my application to have the same config as the intruding config and moved on.I also confirmed that #27821 and #22611 are still problems (and patched up their tests to fail for the right reasons again, so they will hopefully pass when the epic test classloading rewrite ETCR (#34681) is done.