Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources, not resource for path #41886

Merged
merged 2 commits into from
Jul 22, 2024
Merged

resources, not resource for path #41886

merged 2 commits into from
Jul 22, 2024

Conversation

maxandersen
Copy link
Member

noticed the docs uses /resource/ where /resources/ is expected (at least according to rest of docs)

cc @ia3andy @mkouba

Copy link

quarkus-bot bot commented Jul 14, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some additional changes.

@mkouba I'm not sure the order of sections and the flow of this guide is natural tbh but I will let you judge of that.

Copy link

quarkus-bot bot commented Jul 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1738a41.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gsmet gsmet merged commit dad27d6 into main Jul 22, 2024
7 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 22, 2024
Copy link

🙈 The PR is closed and the preview is expired.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.0 Jul 22, 2024
@gastaldi gastaldi deleted the maxandersen-patch-1 branch September 3, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants