-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support record parameter containers #42642
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Naturally, the TCK had to fail… |
Now this is interesting. It fails because the TCK has an public class AppConfig extends Application {
public java.util.Set<java.lang.Class<?>> getClasses() {
Set<Class<?>> resources = new HashSet<Class<?>>();
resources.add(Resource.class);
resources.add(RuntimeExceptionMapper.class);
resources.add(WebApplicationExceptionMapper.class);
return resources;
}
} The javadoc for
And our (new unified) parameter container scanning respects this to exclude the bean params. I don't think bean params fall within the scope of "resource, provider or feature" so I think they should not be filtered out… |
Agreed |
Go back to PTO man ;) I'm just thinking out loud. |
Also unify the parameter container detection code paths Make sure we do not turn record parameter containers into beans For records, we store every contructor parameter in a local variable until we have enough to call the constructor via a generated static method. Fixes quarkusio#19686
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Also unify the parameter container detection code paths Make sure we do not turn record parameter containers into beans
For records, we store every contructor parameter in a local variable until we have enough to call the constructor via a generated static method.
I'll open an issue with the work remaining, but this has already taken me too long to do I need to get back to the other stuff for now :(