Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle subclasses for Kafka Serde autodetection #43262

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Handle subclasses for Kafka Serde autodetection #43262

merged 1 commit into from
Sep 17, 2024

Conversation

ozangunalp
Copy link
Contributor

@ozangunalp ozangunalp commented Sep 13, 2024 •
edited by geoand
Loading

@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

🎊 PR Preview 2b814d3 has been successfully built and deployed to https://quarkus-pr-main-43262-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

Sign in to view
@ozangunalp ozangunalp force-pushed the kafka_serde_autodetect_inherited_classes branch from 1a99be6 to e36f390 Compare September 13, 2024 14:34
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@ozangunalp ozangunalp force-pushed the kafka_serde_autodetect_inherited_classes branch from e36f390 to 8a115a5 Compare September 13, 2024 16:03
@quarkus-bot

This comment has been minimized.

Sign in to view
geoand
geoand reviewed Sep 13, 2024
View reviewed changes
extensions/kafka-client/runtime/pom.xml Outdated
Comment on lines 91 to 102
<plugin>
<groupId>io.smallrye</groupId>
<artifactId>jandex-maven-plugin</artifactId>
<executions>
<execution>
<id>make-index</id>
<goals>
<goal>jandex</goal>
</goals>
</execution>
</executions>
</plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't do this, but instead add the empty beans.xml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For runtime modules of extensions, I've mostly seen the plugin usage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but it's not the preferred way, so let's use the beans.xml way for new stuff please.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, I went with adding individual classes to the index.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better 😉

@quarkus-bot

This comment has been minimized.

Sign in to view
@ozangunalp
Handle subclasses for Kafka Serde autodetection
b635a64 
Added provided serde classes to the jandex index
@ozangunalp ozangunalp force-pushed the kafka_serde_autodetect_inherited_classes branch from 8a115a5 to b635a64 Compare September 16, 2024 17:44
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b635a64.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b635a64.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@ozangunalp ozangunalp merged commit d87b04f into quarkusio:main Sep 17, 2024
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kafka area/reactive-messaging area/smallrye kind/bugfix
Projects
None yet
Milestone
3.16.0.CR1
2 participants
@ozangunalp @geoand