refactor(spring-web): remove validate method after actual validation were removed #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... This doesn't seem right but I'll take a look |
Thanks @geoand. I noticed it as I was checking the spring-web extension. I might be wrong, in that case feel free to close the PR. |
|
OK, now I see, nice catch @machi1990 ! |
geoand
approved these changes
Nov 12, 2019
geoand
added
the
triage/waiting-for-ci
machi1990
force-pushed
the
refactor/remove-validate-method-from-spring-web-extension
branch
from
f068cd5
to
1171566
Compare
machi1990
force-pushed
the
refactor/remove-validate-method-from-spring-web-extension
branch
from
1171566
to
8a693a9
Compare
machi1990
deleted the
refactor/remove-validate-method-from-spring-web-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual validations were removed in 6a6d989 and
bad1edc
/cc @geoand @aureamunoz