-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes deprecated code #5596
Removes deprecated code #5596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to do that after 1.1.0. I really see no rush.
To be fair, I'm even fine to keep them until a 2.x. No harm. |
just remove them from doc (except the migration doc) |
These classes are not used in camel-quarkus. This PR is safe to merge for 1.3.0.Final once someone approves it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scheduled to be in 1.3.0.Final after discussion in protean-dev mailing list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a few questions and pinged a few people. Let's get their feedback before merging this.
Also, have you tested Camel Quarkus?
...rm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/recording/RecordableBootstrap.java
Outdated
Show resolved
Hide resolved
...ent/runtime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientProducer.java
Outdated
Show resolved
Hide resolved
extensions/panache/panache-common/runtime/src/main/java/io/quarkus/panache/common/Sort.java
Show resolved
Hide resolved
Yes, except for This is the error though: [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project camel-quarkus-integration-test-mongodb: Failed to build quarkus application: java.lang.RuntimeException: Failed to load steps from class org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor: Unsupported method parameter class io.quarkus.mongodb.deployment.MongoClientBuildItem at io.quarkus.mongodb.deployment.MongoClientBuildItem arg0 of org.apache.camel.quarkus.core.deployment.CamelRuntimeBeanBuildItem org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor.registerCamelMongoClientProducer(io.quarkus.mongodb.deployment.MongoClientBuildItem,org.apache.camel.quarkus.component.mongodb.CamelMongoClientRecorder) of class org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor -> [Help 1] |
This PR removes the following deprecated classes:
And some deprecated methods from other classes