Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecated code #5596

Merged
merged 6 commits into from
Feb 13, 2020
Merged

Removes deprecated code #5596

merged 6 commits into from
Feb 13, 2020

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Nov 19, 2019

This PR removes the following deprecated classes:

  • SubstrateTest
  • DisabledOnSubstrate
  • DisabledOnSubstrateCondition
  • io.quarkus.infinispan.client.runtime.Remote

And some deprecated methods from other classes

gsmet
gsmet previously requested changes Nov 20, 2019
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to do that after 1.1.0. I really see no rush.

@emmanuelbernard
Copy link
Member

To be fair, I'm even fine to keep them until a 2.x. No harm.

@emmanuelbernard
Copy link
Member

just remove them from doc (except the migration doc)

@Sanne Sanne requested a review from gsmet February 11, 2020 08:49
@gastaldi gastaldi added this to the 1.3.0 milestone Feb 11, 2020
@gastaldi gastaldi removed the triage/on-ice Frozen until external concerns are resolved label Feb 11, 2020
@gastaldi
Copy link
Contributor Author

These classes are not used in camel-quarkus. This PR is safe to merge for 1.3.0.Final once someone approves it

@gastaldi gastaldi mentioned this pull request Feb 11, 2020
@gastaldi gastaldi changed the title Removes deprecated SubstrateTest and condition Removes deprecated code Feb 11, 2020
@gastaldi gastaldi requested a review from geoand February 12, 2020 15:02
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 12, 2020
@gastaldi gastaldi dismissed gsmet’s stale review February 12, 2020 15:06

Scheduled to be in 1.3.0.Final after discussion in protean-dev mailing list

gsmet
gsmet previously requested changes Feb 12, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I added a few questions and pinged a few people. Let's get their feedback before merging this.

Also, have you tested Camel Quarkus?

@gastaldi
Copy link
Contributor Author

Also, have you tested Camel Quarkus?

Yes, except for Camel Quarkus :: Integration Tests :: MongoDB which does not compile with latest Quarkus master (due to other changes - I believe @ppalaga is aware of this), the project builds fine with these changes.

This is the error though:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project camel-quarkus-integration-test-mongodb: Failed to build quarkus application: java.lang.RuntimeException: Failed to load steps from class org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor: Unsupported method parameter class io.quarkus.mongodb.deployment.MongoClientBuildItem at io.quarkus.mongodb.deployment.MongoClientBuildItem arg0 of org.apache.camel.quarkus.core.deployment.CamelRuntimeBeanBuildItem org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor.registerCamelMongoClientProducer(io.quarkus.mongodb.deployment.MongoClientBuildItem,org.apache.camel.quarkus.component.mongodb.CamelMongoClientRecorder) of class org.apache.camel.quarkus.component.mongodb.deployment.MongoDbProcessor -> [Help 1]

@gastaldi gastaldi requested a review from gsmet February 13, 2020 19:08
@gastaldi gastaldi dismissed gsmet’s stale review February 13, 2020 22:01

Changes addressed

@gastaldi gastaldi merged commit aff040f into quarkusio:master Feb 13, 2020
@gastaldi gastaldi deleted the remove_substrate_test branch February 13, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants