Skip shamrock:dev on projects that do not have the build goal configured #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
shamrock-dev-ignore
branch
from
caf9a46
to
b4f7ebe
Compare
mkouba
reviewed
Jan 18, 2019
|
|
||
| boolean found = false; | ||
| for(Plugin i : project.getBuildPlugins()) { | ||
| if(i.getGroupId().equals("org.jboss.shamrock") && i.getArtifactId().equals("shamrock-maven-plugin")) { |
There was a problem hiding this comment.
I think it would be reasonable to use some shared constants here... for groupId, plugin name, etc.
There was a problem hiding this comment.
Let me take over this task. I need to fix the different variable format and will inject the "right" groupId and artifactId (coming from Maven filtering and not constants).
stuartwdouglas
force-pushed
the
shamrock-dev-ignore
branch
from
b4f7ebe
to
ec8929e
Compare
…oal configured This allows Shamrock to work in multi-module project, the dev goal will only be run for the actual shamrock app, not parent poms or support libraries.
stuartwdouglas
force-pushed
the
shamrock-dev-ignore
branch
from
ec8929e
to
048f697
Compare
cescoffier
approved these changes
Jan 19, 2019
|
Merging, as I provide my improvements in a separated PR as it's not only about this task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Shamrock to work in multi-module project, the dev goal will only
be run for the actual shamrock app, not parent poms or support libraries.