Feature/channel management #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Jul 9, 2020
jordens
approved these changes
Jul 9, 2020
jordens
reviewed
Jul 9, 2020
jordens
requested changes
Jul 13, 2020
jordens
requested changes
Jul 17, 2020
src/rf_channel.rs
Outdated
|
|
||
| /// Disable the channel and power it off. | ||
| pub fn disable(&mut self) -> Result<(), Error> { | ||
| self.pins.power_down_channel(); |
There was a problem hiding this comment.
It does matter and let's not risk it. The PA datasheet, the schematic, and the current code all insist on this sequence (rf off, then pinching off before removing the drain voltage).
disable() is just the reverse of enable().
jordens
approved these changes
Jul 17, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the top-level API needed for adding the RF channel management task to RTIC.
It also adds support for configuring alarms on channels, measuring channel characteristics, and disabling channels. The only unimplemented feature is enabling a channel, which is intentionally omitted for safety reasons until we can verify the functionality of the interlock thresholds in #3.
This addresses most of #5