Correctly normalize to forward slash the path when creating tar.gz for Posit Connect deploys #8784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Connect deploys `std/archive/tar.ts` will create folders based on file paths used, but it requires using `/` and not `\` in path. This is a problem on Windows, where the path separator is `\`. This commit adds a check to normalize the path to use `/` instead of `\` when creating the tar.gz file for Connect deploys.
|
Yes, we definitely want to backport this. It should just be a matter of cherry-picking the commit and adding to the 1.4 changelog. Do you want to do that? |
|
OK I'll do that - it would be great I know how to so this is good opportunity. I'll reach out if question |
|
I have backported to v1.4 and added the changelog there. Merging this in main now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std/archive/tar.tswill create folders based on file paths used, but it requires using/and not\in path. This is a problem on Windows, where the path separator is\. This commit adds a check to normalize the path to use/instead of\when creating the tar.gz file for Connect deploys.fixes #8749
Opening as a PR as I want to be sure the
manifest.jsonfile needs also normalizing or not.Test shows it works with only this fix.
@cscheid as this impact Posit connect deploys, and this is quite scoped, could we target this for our next path release of 1.4 ?