Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Aug 15, 2022

This PR proposes a GitHub Action to tag and make a GitHub release with GitHub changelog on commits following the pattern 'release vX.X.X'.
GHA is triggered by a commit message starting with 'release'.
Tag/Release name are set with anything after 'release ', i.e., from 'release vX.X.X' commit message, the tag will be 'vX.X.X'.

Fixes #58

@jjallaire
Copy link
Contributor

Thanks!!! One other thing we should almost certainly do is attach the actual VSIX file to the release (which will provide a nice archive of previous release -- currently something you need to traverse the repo history for). Eventually we should actually build the VSIX in CI and stop checking it in to the repo but that can be for another day.

@mcanouil
Copy link
Contributor Author

To note, from VSCode anyone can install any previous version of any extension without having to go to the repository nor marketplace.
This is why, I thought for now a simple tag/release would be enough (also this reduces the amount of stuff to store on data servers).

Screen.Recording.2022-08-15.at.15.16.48.mov

@mcanouil
Copy link
Contributor Author

mcanouil commented Aug 15, 2022

@eitsupi & @jjallaire Maybe the GHA from the vscode-r extension could be used (or at least serve as a basis)?
It could be combined with my proposed GHA which could lead to the following workflow:

  1. commit message: 'release vX.X.X'
  2. build vscode-quarto
  3. set tag from commit message
  4. set release
  5. publish to Visual Studio Marketplace

(if the build step fails, there is no tag/release)

https://github.com/REditorSupport/vscode-R/blob/master/.github/workflows/release.yml

@eitsupi
Copy link
Contributor

eitsupi commented Aug 15, 2022

To note, from VSCode anyone can install any previous version of any extension without having to go to the repository nor marketplace.

Visual Studio Marketplace is only available from Microsoft products.
In general, you must use Open VSX or install directly except for Microsoft products.

The Julia extension seems to automatically make releases to both Visual Studio Marketplace and Open VSX.
https://github.com/julia-vscode/julia-vscode/blob/d7b219cb42611162aa8f20fa9d5e5042e7fcb8c2/.github/workflows/main.yml

@mcanouil
Copy link
Contributor Author

I see thanks for the information.

https://github.com/REditorSupport/vscode-R/blob/master/.github/workflows/release.yml

By the way, for vscode-r, the Open VSX was disabled (commented) last month in the GHA workflow for some reason

@jjallaire jjallaire merged commit 4e0e57a into quarto-dev:main Aug 24, 2022
@mcanouil mcanouil deleted the auto-tag-release-on-commit branch August 31, 2022 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tag/Release when extension is updated on martketplace?

3 participants