-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for EL6 (init scripts) #33
Conversation
- Presence of init scripts causes a conflict on RHEL9 if installing also the chkconfig package Fixes quattor#27
7796374
to
4853946
Compare
- Use of /var/run generates a warningin EL9 - Supported since EL7 where /var/run is a symlink to /run
Tested successfully at IJCLab (EL9). |
this removes support for init.d completly. is this ok, also for el7? and why don't you actually remove the script in src/main/daemon? |
from what I've noticed, building a package with this PR, I see chkconfig dependency is removed but /etc/init.d/cdp-listend still being installed. So therefore /etc/init.d dir is being created and I still see the error if chkconfig package is installed later.
so don't you also need to update pom.xml?
with this change, it does not have any reference to /etc/init.d/cdp-listend in the resulting built rpm. |
@aka7 I confirm your findings. According to what I see on the machines I deployed with this PR the path doesn't seem to be in the rpm anymore but better to clean it. I'll do it. |
@aka7 I just pushed the suggested cleanup in pom.xml |
No description provided.