Removes default CSS margins on viewport #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to hooks stories
…lcom CLI: Force welcome stories to show up first in load order
…book into mdx-empty-story
Addon-docs: Error handling for invalid Story id
# Conflicts: # addons/contexts/package.json
Update package.json
…rybookjs#8061) Addon-docs: CSS classes for escape-hatch theming wrapper/content
Add tests and src to npmignore Co-authored-by: Dmitriy Kuznetsov <d.o.kuznetsov@tinkoff.ru> Co-authored-by: Norbert de Langen <ndelangen@me.com>
…rybookjs#7738) Strip comments of angular.json and tsconfig.json in @storybook/angular Co-authored-by: Norbert de Langen <ndelangen@me.com>
Update README.md
fix: Allow JSX.Element story
Bumps [graphiql](https://github.com/graphql/graphiql) from 0.13.2 to 0.14.2. - [Release notes](https://github.com/graphql/graphiql/releases) - [Changelog](https://github.com/graphql/graphiql/blob/master/CHANGELOG.md) - [Commits](https://github.com/graphql/graphiql/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump graphiql from 0.13.2 to 0.14.2 Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
Improve error logging Co-authored-by: Norbert de Langen <ndelangen@me.com>
Bumps [pnp-webpack-plugin](https://github.com/arcanis/pnp-webpack-plugin) from 1.4.3 to 1.5.0. - [Release notes](https://github.com/arcanis/pnp-webpack-plugin/releases) - [Commits](https://github.com/arcanis/pnp-webpack-plugin/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump pnp-webpack-plugin from 1.4.3 to 1.5.0 Co-authored-by: null <27856297+dependabot-preview[bot]@users.noreply.github.com>
ndelangen
force-pushed
the
patch-issue-7724
branch
from
75fb3c0
to
4df4e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue storybookjs#7724 and PR#7640
What I did
This resets the default CSS margins on the body element. This prevents having vertical and horizontal scrollbars on the preview viewport as is the case in version 5.1.10, for instance.
This also fixes a regression on the latest version compared to the live examples running on 5.1.3, where there is no whitespace around the preview area.
This 8px whitespace -- the browsers' default margin on the body -- around the preview area is not desirable in my opinion, especially when the previewed component has a width of 100% or is simply a block element.