Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally addresses a bug in disaffecting the display of the text boxes at the beginning of each level in Marble Madness; this is what it looked like previously:
After ruling out a ton of other possibilities, namely the implementations behind caching and rendering of tile data by the PPU, it turned out that it was a fairly trivial mapping issue. In the case of the Marble Madness game, it uses the
singleScreen1
mirroring strategy and previously we were incorrectly computing actual nametable indices for it.The fix was to update the mapping, this time representing it as a two-dimensional array instead of a switch/case statement. Also the mapping has been moved into the
Mirroring
enum, and an instance method added there to return the correct nametable index for a given mirroring strategy and inbound nametable index. And now everything renders perfectly:Other fixes/updates included in this PR:
readByteInternal()
no longer returns a tuple.