-
Notifications
You must be signed in to change notification settings - Fork 41
Add folder syncing #27
Conversation
copyIfChanged(file, file2); | ||
} else { | ||
file2.mkdir(); | ||
syncFiles(file, file2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you're recursing here, would it be reasonable to add a test case that reflects a structure of directories with files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I added a simple test case for it.
Take asynchronous compilation execution into account
Another interesting thing on the file sync is create a temp directory inside the project target folder, not on the system temp. |
I think that limiting ourselves to the confines of the target directory is better yes. Currently, we generate a temp directory, which we don't clean up. |
@luisfpg Are there still issues with the implementation? |
@timowest No more issues - everything I tested worked as expected.
Congratulations! |
@Shredder121 Is this good to merge? |
Aside from maybe cleaning up the directory this looks fine yes. |
Which directory needs to be ckeaned up?
|
Nevermind, only in the test case ( This is good to merge note that I can't merge, as I don't have write access in this repository, so you'll have to do it |
@Shredder121 I added you now to the contributors of all querydsl org repositories. |
AH, so I see, yes. Thank you very much. |
And then we have to update the docs again using 1.1.3? |
Fixes #26