MS SQL Server: replace old, unmaintained jTDS driver with mssql-jdbc #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new driver revealed a bug in UtilDateType. java.util.Date internally represents the date as milliseconds UTC, but externally the date is represented in the current timezone. Therefore I have changed UtilDateType to be consistent with TimezoneType. |
jwgmeligmeyling
approved these changes
Oct 6, 2022
|
Thanks! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jTDS driver has not been updated in many years and is not JDBC 4.2 (Java 8) compliant. Since Microsoft has open-sourced their official JDBC driver, it makes sense to switch to that instead.
This PR is a prerequisite for #3402, as mentioned in that PR.
In case there are any questions about the use of
sendTimeAsDatetime=falsein the connection string: this is necessary for tests related tojava.sql.Timeto work, as per footnote 1 in the official MS docs.