Skip to content

Conversation

davidanthoff
Copy link
Member

This makes a big difference if that code path is hit. For my example file, I go from something like 2.8s to 2.0s.

@davidanthoff davidanthoff requested a review from shashi December 24, 2018 22:48
@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files          11       11           
  Lines        1153     1153           
=======================================
  Hits          862      862           
  Misses        291      291
Impacted Files Coverage Δ
src/field.jl 78.87% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34a12a...e175c2d. Read the comment docs.

@shashi shashi merged commit ccc3d02 into queryverse:master Jan 3, 2019
@davidanthoff davidanthoff deleted the precompute-doubledouble branch January 3, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants