Skip to content

chore: minor fixes to examples manifest file and reduced python test flakyness #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2024
Merged

chore: minor fixes to examples manifest file and reduced python test flakyness #55

merged 3 commits into from
Mar 12, 2024

Conversation

amunra
Copy link
Collaborator

@amunra amunra commented Mar 12, 2024 •
edited
Loading

Minor cleanup and fixes, not related to core functionality.

Test improvements:

  • Split out building the TLS proxy into own command so it does not contribute to the start-up time, reducing flakyness on slow CI.
  • Testing that the examples.manifest.yaml file can be parsed as YAML.

Fixes:

  • Fixed the examples.manifest.yaml file.

@amunra amunra changed the title split out tls proxy compile time on slower ci to separate step chore: minor fixes to examples manifest file and reduced python test flakyness Mar 12, 2024
@amunra amunra marked this pull request as ready for review March 12, 2024 16:37
@amunra amunra requested a review from insmac March 12, 2024 16:38
@amunra amunra mentioned this pull request Mar 12, 2024
Closed
@amunra amunra requested a review from goodroot March 12, 2024 17:03
@amunra amunra merged commit a971a24 into main Mar 12, 2024
@amunra amunra deleted the ilp_conf_cleanup branch March 12, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@insmac insmac Awaiting requested review from insmac

1 more reviewer

@goodroot goodroot goodroot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amunra @goodroot