Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi buffer support in editor #65

Draft
wants to merge 72 commits into
base: main
Choose a base branch
from
Draft

multi buffer support in editor #65

wants to merge 72 commits into from

Commits on Sep 30, 2022

  1. Multi-buffer editor PoC

    @insmac
    insmac committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c96693a View commit details
    Browse the repository at this point in the history

  2. pass-through prop

    @insmac
    insmac committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    f1cb613 View commit details
    Browse the repository at this point in the history

  3. Add file rename

    @insmac
    insmac committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    606db6b View commit details
    Browse the repository at this point in the history

  4. simplify editor tabs code

    @insmac
    insmac committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    737af34 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Cleanup renaming

    @insmac
    insmac committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    e1507e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'web-console/multi-buffer' of https://github.com/questdb/ui 

     into web-console/multi-buffer
    @insmac
    insmac committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    90c125b View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @insmac
    insmac committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    98c1f9f View commit details
    Browse the repository at this point in the history

  4. Update value on rename

    @insmac
    insmac committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    e8fc587 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge branch 'main' into web-console/multi-buffer

    @argshook
    argshook committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    88fe488 View commit details
    Browse the repository at this point in the history

  2. add uuid

    @argshook
    argshook committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    af41142 View commit details
    Browse the repository at this point in the history

  3. rename file -> buffer and use id instead of label

    @argshook
    argshook committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    615c02c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. extract label to component

    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    196bf4b View commit details
    Browse the repository at this point in the history

  2. set value to buffers

    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    65e0038 View commit details
    Browse the repository at this point in the history

  3. add dexie and dexie-react-hooks 

    for indexedDB management
    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    772b3fa View commit details
    Browse the repository at this point in the history

  4. use dexie for buffers storage 

    also extract buffers to dedicated files
    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f7f3534 View commit details
    Browse the repository at this point in the history

  5. fix everything

    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    3dcd6f6 View commit details
    Browse the repository at this point in the history

  6. remove uuid and @types/uuid 

    no need, cause dexie does incremental id
    @argshook
    argshook committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    05094fe View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. save activeBufferId to db

    @argshook
    argshook committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    094330c View commit details
    Browse the repository at this point in the history

  2. set active buffer after deleting one

    @argshook
    argshook committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    346ec50 View commit details
    Browse the repository at this point in the history

  3. populate buffer from local storage

    @argshook
    argshook committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    772fa7a View commit details
    Browse the repository at this point in the history

  4. remove query_text after popoulating indexedDB

    @argshook
    argshook committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f7663f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. refactor editor provider

    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    44d2e32 View commit details
    Browse the repository at this point in the history

  2. remove getValue 

    seems unused. and `getValue` is already available on
`editorRef.current.getValue`
    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    769cd84 View commit details
    Browse the repository at this point in the history

  3. refactor Monaco file 

    extract editor actions to dedicated file
refactor types
    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8fd0890 View commit details
    Browse the repository at this point in the history

  4. extract language addons to file

    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e4a4e2b View commit details
    Browse the repository at this point in the history

  5. extract legacy event bus action to dedicated file 

    for easier refactoring in future
    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c238fd3 View commit details
    Browse the repository at this point in the history

  6. save editorViewState to indexedDB

    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b58a0e0 View commit details
    Browse the repository at this point in the history

  7. remove localStorage preferences 

    it is now indexedDB
    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5bbf93d View commit details
    Browse the repository at this point in the history

  8. fix default editorViewState

    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    18ef1ca View commit details
    Browse the repository at this point in the history

  9. preserve viewState when switching tabs

    @argshook
    argshook committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    f962535 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. add hack to restoreViewState on initial load

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b4aa8bc View commit details
    Browse the repository at this point in the history

  2. wrap EditorProvider right in Editor component

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    625dcb3 View commit details
    Browse the repository at this point in the history

  3. refactor restoreViewState hack

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5f795d7 View commit details
    Browse the repository at this point in the history

  4. fix buffer deleting and state save

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    143176c View commit details
    Browse the repository at this point in the history

  5. fix types and rename editorReadyHook -> editorReadyTrigger

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d264f09 View commit details
    Browse the repository at this point in the history

  6. fix tab renaming

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5c917ed View commit details
    Browse the repository at this point in the history

  7. add new buffer when ?query is used

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    582a965 View commit details
    Browse the repository at this point in the history

  8. fix executeQuery for addBuffer

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f9592cd View commit details
    Browse the repository at this point in the history

  9. use addBuffer for example quries

    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    cd6b652 View commit details
    Browse the repository at this point in the history

  10. done check for buffer.value 

    it might have `""` which is valid value, but then `setModel` wouldn't
work
    @argshook
    argshook committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    4a84c2a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. fix add button in schema

    @argshook
    argshook committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3d04f1b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'main' into web-console/multi-buffer

    @argshook
    argshook committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    18a40ed View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge branch 'main' into web-console/multi-buffer

    @argshook
    argshook committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    cdc5b0f View commit details
    Browse the repository at this point in the history

  2. add keyboard shortcuts 

    alt+t to open tab
alt+w to close tab
    @argshook
    argshook committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    966ef6a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. add getAll to buffers store API

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5ab9325 View commit details
    Browse the repository at this point in the history

  2. make sure at least one buffer is available

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4a2817b View commit details
    Browse the repository at this point in the history

  3. prevent closing tab with alt+w when only one in total

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c9dab7f View commit details
    Browse the repository at this point in the history

  4. fix buffer deletion and state save

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    a4b138a View commit details
    Browse the repository at this point in the history

  5. show close context menu entry only when buffers.length > 1

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9063116 View commit details
    Browse the repository at this point in the history

  6. disallow renaming tab to empty string

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    25c0616 View commit details
    Browse the repository at this point in the history

  7. fix browser-tests to work with multi buffers

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c1ff7ee View commit details
    Browse the repository at this point in the history

  8. for QueryPicker add new buffer if current non empty

    @argshook
    argshook committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    78d5033 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. upgrade cypress to v10

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7770082 View commit details
    Browse the repository at this point in the history

  2. migrate cypress config to v10

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    41e49f9 View commit details
    Browse the repository at this point in the history

  3. add few browser tests for tabs

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c9b0e9a View commit details
    Browse the repository at this point in the history

  4. add another test

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0f9c5bc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into web-console/multi-buffer

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8601d48 View commit details
    Browse the repository at this point in the history

  6. fix keyboard shortcut test 

    there's a bug in implementation
    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3534e97 View commit details
    Browse the repository at this point in the history

  7. do not set activebuffer for already active buffer

    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c4c4bfe View commit details
    Browse the repository at this point in the history

  8. remove double click to rename feature 

    it's more troublesome than helpful
    @argshook
    argshook committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    b27eda6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. fix bug found by tabs test

    @argshook
    argshook committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    ac321d5 View commit details
    Browse the repository at this point in the history

  2. fix active tab highlight when removing all with keyboard shortcut

    @argshook
    argshook committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    35130c7 View commit details
    Browse the repository at this point in the history

  3. add license banner

    @argshook
    argshook committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    de32874 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. wip tab UI and scrolling

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4188e1d View commit details
    Browse the repository at this point in the history

  2. scroll into view active tab

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ee6b6b6 View commit details
    Browse the repository at this point in the history

  3. keep focus on editor after closing tab

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    7451e98 View commit details
    Browse the repository at this point in the history

  4. keep editor focus when clicking active tab

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    891c442 View commit details
    Browse the repository at this point in the history

  5. adjust tab style

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a627d96 View commit details
    Browse the repository at this point in the history

  6. ensure tab text is not trimmed vertically

    @argshook
    argshook committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    7760ed0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. add tab open/close shortcuts info

    @argshook
    argshook committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9cb44fa View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge branch 'main' into web-console/multi-buffer

    @argshook
    argshook committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    bb3d046 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into web-console/multi-buffer

    @bluestreak01
    bluestreak01 authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    929560f View commit details
    Browse the repository at this point in the history