-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi buffer support in editor #65
base: main
Are you sure you want to change the base?
Conversation
for indexedDB management
also extract buffers to dedicated files
no need, cause dexie does incremental id
seems unused. and `getValue` is already available on `editorRef.current.getValue`
extract editor actions to dedicated file refactor types
768f44f
to
8fd0890
Compare
for easier refactoring in future
there is tab flicker when new tab is added: QuestDB.Console.-.Google.Chrome.2022-10-27.11-09-19.mp4 |
when there are too many tabs, UX is terrible: QuestDB.Console.-.Google.Chrome.2022-10-27.11-14-30.mp4Compare this to Chrome UX at the same position: New.Tab.-.Google.Chrome.2022-10-27.11-16-14.mp4 |
there's a bug in implementation
it's more troublesome than helpful
let me summarise my feedback ergonomics of the editor(s)
ergonomics of the tabs
I am happy to help with all of this, but I will need pointers on how to do this in react efficiently. Perhaps some time to walk me thru the relevant code base ? |
@bluestreak01 thanks, Vlad, this is really helpful! I'll gromulate these points in my head and will get back to you |
This PR implements support for multiple editor tabs
+
next to last tabalt + t
keyboard shortcutx
on tabalt + w
keyboard shortcut(not
localStorage
anymore). This way no need to worry about 5MBbrowser storage limit, user can have as many tabs with as much content
as they like
position was saved. In addition to those, this PR now saves and
restores text selection, scroll position and code folds
like "reopen closed tabs" and "tab drawer" will be trivial