Skip to content

Check permission to access the question #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

Check permission to access the question #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lang/en/assignsubmission_qpy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@
$string['enabled_help'] = 'If enabled, students are able to answer QuestionPy questions.';
$string['eventassessableuploaded'] = 'QuestionPy assessable uploaded';
$string['gotnosubmission'] = 'No submission data available. Please try again.';
$string['grademustbepoint'] = 'QuestionPy submissions require grade type "point".';
$string['pluginname'] = 'QuestionPy submission';
$string['questionnopermission'] = 'You do not have permission to access this question or this question is not in the current course.';
$string['questionnotfound'] = 'Question not found.';
$string['questionnotgradable'] = 'The question was not answered or was answered incompletely.';
$string['questionpyrequired'] = 'Only QuestionPy questions are allowed.';
$string['submissionnotfound'] = 'No question submission found.';
30 changes: 27 additions & 3 deletions locallib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,37 @@ public function settings_validation(array $data, array $files): array {
global $DB;

$errors = [];
if (!$DB->record_exists('question_versions', ['questionid' => $data['assignsubmission_qpy_questionid']])) {
$questionid = $data['assignsubmission_qpy_questionid'];

// Check that the question exists.
if (!$DB->record_exists('question_versions', ['questionid' => $questionid])) {
$errors['assignsubmission_qpy_questionid'] = get_string('questionnotfound', 'assignsubmission_qpy');
return $errors;
}

// User must be allowed to view/use the question. In addition, we also require the question to be in the same
// course as this assign activity. Moodle supports using questions from other courses,
// but this requirement is safer for us (in case we forgot some additional checks).
$question = question_bank::load_question($questionid);
$questioncoursecontext = context::instance_by_id($question->contextid)->get_course_context();
$assigncoursecontext = $this->assignment->get_context()->get_course_context();
if (
$questioncoursecontext->id != $assigncoursecontext->id ||
!question_has_capability_on($question, 'use') ||
!question_has_capability_on($question, 'view')
) {
$errors['assignsubmission_qpy_questionid'] = get_string('questionnopermission', 'assignsubmission_qpy');
} else if (!$question instanceof \qtype_questionpy_question) {
// Only QuestionPy questions are allowed.
$errors['assignsubmission_qpy_questionid'] = get_string('questionpyrequired', 'assignsubmission_qpy');
}

// Check grade type to be point.
if ($data['grade'] <= 0) {
$errors['grade'] = get_string('grademustbepoint', 'assignsubmission_qpy');
}

return $errors;
// TODO: Check permissions.
// TODO: Check grade type "point" selected.
}

/**
Expand Down