Adding Support for Python3.10 #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abukhoy It seems the line endings have changed, causing all lines to appear as modified. Could you please switch the line endings to either ‘CRLF’ or ‘LF’ in your code editor and push the changes again? |
|
@quic-rishinr formatting is done now. |
abukhoy
force-pushed
the
python_3.10
branch
2 times, most recently
from
29fea70 to
da73cee
Compare
|
LGTM |
quic-amitraj
approved these changes
Oct 28, 2024
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
quic-rishinr
reviewed
Nov 4, 2024
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com>
|
LGTM |
asmigosw
approved these changes
Nov 4, 2024
quic-amitraj
requested changes
Nov 4, 2024
quic-amitraj
approved these changes
Nov 4, 2024
quic-akuruvil
pushed a commit
to quic-akuruvil/efficient_transformers
that referenced
this pull request
Nov 12, 2024
* fixing the EOL Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * changing torch to 2.5.0 Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv installation in Jenkins Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * reverting the installation instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction with sudo Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Update Jenkinsfile Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> * Removing torch=2.5.0 from this PR Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Fixing Format Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * README updated Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * LF formatted Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> --------- Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> Co-authored-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com>
eplatero97
pushed a commit
to quic-agokhale/efficient-transformers
that referenced
this pull request
Nov 13, 2024
* fixing the EOL Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * changing torch to 2.5.0 Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv installation in Jenkins Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * reverting the installation instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction with sudo Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Update Jenkinsfile Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> * Removing torch=2.5.0 from this PR Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Fixing Format Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * README updated Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * LF formatted Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> --------- Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> Co-authored-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com>
eplatero97
pushed a commit
to quic-agokhale/efficient-transformers
that referenced
this pull request
Nov 13, 2024
* fixing the EOL Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * changing torch to 2.5.0 Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv installation in Jenkins Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * reverting the installation instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * adding python3.10-venv instruction with sudo Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Update Jenkinsfile Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> * Removing torch=2.5.0 from this PR Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * Fixing Format Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * README updated Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> * LF formatted Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> --------- Signed-off-by: Abukhoyer Shaik <quic_abukhoye@quicinc.com> Signed-off-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> Co-authored-by: Amit Raj <168538872+quic-amitraj@users.noreply.github.com> Signed-off-by: eplatero <quic_eplatero@quicinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here to support python3.10, created a python3.10 enviroment and changed the torch version to 2.0.0 only.
Tested on both local machines x86 and ARM.