Fix llama model o_proj lora_ids passing for finite lorax #575
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-jouachen
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-jouachen
force-pushed
the
finitelorax_oproj_fix
branch
2 times, most recently
from
be20bee to
1017339
Compare
quic-rishinr
approved these changes
Oct 9, 2025
Signed-off-by: Jou-An Chen <quic_jouachen@quicinc.com>
quic-rishinr
force-pushed
the
finitelorax_oproj_fix
branch
from
1017339 to
f3ba870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding the issue reported in #572
The finite lorax feature failed to execute when testing on a llama adapter (jumip/llama-lora-adapter) that contains o_proj as target module.
Work in progress -- test to be added to avoid future regression