Skip to content

Switch to using the xsum small accumulator #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Switch to using the xsum small accumulator #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c543abf
Switch to using the xsum small accumulator
saghul Apr 3, 2025
49e1ae6
Trim xsum to only the small accumulator
saghul Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44727,7 +44727,7 @@ static JSValue js_math_sumPrecise(JSContext *ctx, JSValueConst this_val,
JSValue iter, next, item, ret;
int done;
double d;
xsum_large_accumulator lacc;
xsum_small_accumulator acc;
SumPreciseStateEnum state;

iter = JS_GetIterator(ctx, argv[0], /*async*/false);
Expand All @@ -44737,7 +44737,7 @@ static JSValue js_math_sumPrecise(JSContext *ctx, JSValueConst this_val,
next = JS_GetProperty(ctx, iter, JS_ATOM_next);
if (JS_IsException(next))
goto fail;
xsum_large_init(&lacc);
xsum_small_init(&acc);
state = SUM_PRECISE_STATE_MINUS_ZERO;
for (;;) {
item = JS_IteratorNext(ctx, iter, next, 0, NULL, &done);
Expand Down Expand Up @@ -44773,7 +44773,7 @@ static JSValue js_math_sumPrecise(JSContext *ctx, JSValueConst this_val,
state = SUM_PRECISE_STATE_MINUS_INFINITY;
else if (!(d == 0.0 && signbit(d)) && (state == SUM_PRECISE_STATE_MINUS_ZERO || state == SUM_PRECISE_STATE_FINITE)) {
state = SUM_PRECISE_STATE_FINITE;
xsum_large_add1(&lacc, d);
xsum_small_add1(&acc, d);
}
}
}
Expand All @@ -44792,7 +44792,7 @@ static JSValue js_math_sumPrecise(JSContext *ctx, JSValueConst this_val,
d = -0.0;
break;
case SUM_PRECISE_STATE_FINITE:
d = xsum_large_round(&lacc);
d = xsum_small_round(&acc);
break;
default:
abort();
Expand Down
Loading