Skip to content

Use poll() instead of select() in js_os_poll #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2025
Merged

Use poll() instead of select() in js_os_poll #1097

merged 2 commits into from
Jun 8, 2025

Conversation

bnoordhuis
Copy link
Contributor

It's not safe to add file descriptors > FD_SETSIZE (usually 1,024) to a fd_set, it writes beyond the buffer. Switch to poll(2).

Fixes: #1096

bnoordhuis added 2 commits June 8, 2025 16:39
@bnoordhuis
Use poll() instead of select() in js_os_poll
7031ee3 
It's not safe to add file descriptors > FD_SETSIZE (usually 1,024) to
a fd_set, it writes beyond the buffer. Switch to poll(2).

Fixes: quickjs-ng#1096
@bnoordhuis
squash! fix wasi maybe?
98d8f38
saghul
saghul approved these changes Jun 8, 2025
View reviewed changes
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@bnoordhuis bnoordhuis merged commit f0849ad into quickjs-ng:master Jun 8, 2025
126 of 127 checks passed
@bnoordhuis bnoordhuis deleted the fix1096 branch June 8, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use select(2) in js_os_poll
2 participants
@bnoordhuis @saghul