Make quickjs-libc symbols visible at link time #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotate functions in quickjs-libc.h with the proper visibility like we do in quickjs.h, otherwise they are hidden (and produce missing symbol errors) when trying to link against the shared library. Fixes: quickjs-ng#1152
saghul
approved these changes
Sep 15, 2025
|
Thanks, I'm trying to replace quickjs in debian by quickjs-ng, ideally as a shared library. That will give some asynchronous CI ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate functions in quickjs-libc.h with the proper visibility like we do in quickjs.h, otherwise they are hidden (and produce missing symbol errors) when trying to link against the shared library.
Fixes: #1152
I considered adding a CI buildbot but we're already kind of top-heavy and I couldn't find a suitable existing one to repurpose.