-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream #235
Sync with upstream #235
Conversation
@@ -11110,8 +11110,10 @@ static void js_dtoa1(char (*buf)[JS_DTOA_BUF_SIZE], double d, | |||
} else if (flags == JS_DTOA_VAR_FORMAT) { | |||
int64_t i64; | |||
char buf1[70], *ptr; | |||
if (d > (double)MAX_SAFE_INTEGER || d < (double)-MAX_SAFE_INTEGER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnoordhuis See past action runs for the error. Let me know what you think of this.
gcc renamed the built-in type from |
I can apply the patch, or we can wait for someone to complain... :-) |
I'd wait :) That patch is.... let's say suboptimal. It'd be better to switch to (I think the type was introduced in 3.x. I hope we don't plan on supporting that.) |
Skipped (for now):