Improve string parsing and JSON parsing #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chqrlie
commented
Mar 15, 2024
chqrlie
commented
- fix JSON parsing of non ASCII string contents
- fix html comment detection at start of source code
- more precise string parsing errors
- more precise JSON parsing errors
- ignore more v8 tests
- improve v8 Failure messages
- fix JSON parsing of non ASCII string contents - fix html comment detection at start of source code - more precise string parsing errors - more precise JSON parsing errors - ignore more v8 tests - improve v8 Failure messages
- fix side effects of `s->token.len = -1` initialization - use more reliable method for HTML comment detection - add `JS_ParseState::buf_start` to compute line/column
bnoordhuis
approved these changes
Mar 19, 2024
Comment on lines
+18705
to
+18706
| } else | ||
| if ((c >= '0' && c <= '9') |
There was a problem hiding this comment.
I'll never get used to this style :-)
v8-tweak.js
Outdated
| print(String(message).slice(0, 300)) | ||
| } | ||
| globalThis.formatFailureText = function(expectedText, found, name_opt) { | ||
| var message = "Fail" + "ure"; |
There was a problem hiding this comment.
I'll never get used to this style :-)
- remove semicolons in v8.js - filter out omit-default-ctors-array-iterator.js
bnoordhuis
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.