Improve REPL directive support #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use . on column 0 as directive prefix - use `directives` object properties for genericity - accept non ambiguous directive abbreviations - simplify `handle_directive` and `handle_cmd`
saghul
reviewed
Apr 8, 2024
| std.loadScript(filename); | ||
| return true; | ||
| } | ||
| if (a[0] !== '\\' && a[0] !== '.') |
There was a problem hiding this comment.
If we are switching to dot directives, it feeels weird to get .quit in the docs, for example, but for \quit to also work.
Also, \quit() and \quit123 also work, which is arguably wrong.
There was a problem hiding this comment.
I agree .quit() and \quit123 should be rejected. Will do.
I switched to . directives because they are more readable and that's what node uses, I kept backslash for muscle memory, but I should probably remove it at some point.
repl.js
Outdated
| "\\clear clear the terminal\n" + | ||
| "\\q exit\n"); | ||
| var sel = (n) => n ? "*": " "; | ||
| std.puts(".help this help\n" + |
There was a problem hiding this comment.
Yes, definitely. Will do.
Yes. Good point. |
- reject invalid directive with extra characters - document ".load"
saghul
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directivesobject properties for genericityhandle_directiveandhandle_cmd