Skip to content

Fix performance.now() to return a double #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix performance.now() to return a double #381

merged 1 commit into from
Apr 15, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Apr 15, 2024

No description provided.

@chqrlie
Copy link
Collaborator

chqrlie commented Apr 15, 2024

For consistency, you should make ctx->time_origin a double too.

@saghul
Copy link
Contributor Author

saghul commented Apr 15, 2024

Ops, good catch! Fixed.

@saghul saghul merged commit 18c632c into master Apr 15, 2024
@saghul saghul deleted the perf-now-double branch April 15, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chqrlie chqrlie chqrlie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @chqrlie