Simplify Array.fromAsync lazy loading #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -C as the complementary to the -m flag to qjsc that compiles the input as an ES module. Add -C as a shorthand alias for --script to qjs and harmonize the qjs and qjsc help messages. Capital C because -c is already taken.
Store it as classic JS instead of an ES module that we need to pull apart first. Added benefit is that it shrinks the serialized representation by 5%.
saghul
approved these changes
Mar 17, 2025
|
Unrelated: shall we move this one header file to the root, since it simplifies the "copy a bunch of c and h files" build method? |
|
Will the |
Replying to myself: yes, it will. I don't strongly object but I like about the current setup that gen/ clearly indicates it's auto-generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store it as classic JS instead of an ES module that we need to pull
apart first.
Added benefit is that it shrinks the serialized representation by 5%.
First commit is #978, necessary for the -C flag to qjsc.