-
Notifications
You must be signed in to change notification settings - Fork 78
Add function #'ADD-LOCAL-PROJECTS-TO-MANIFEST #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for working on this. I think I'd like slightly different behavior:
For that final point, I don't know if that means the local-projects must precede or succeed the Quicklisp-provided systems...double check the manifest file code in buildapp to be sure. Do you feel like revising your code to do that? If not, I can look into doing it myself this weekend. |
The new keyword argument should be added to |
Sure, I'll do it. Thanks for your review. |
Still need to check the precedence of local systems. Still working on that. |
The function Did I implement it properly? |
One last thing - if |
Thank you, things look great! There's one last thing that I noticed that might be a potential issue. Entries in the manifest file should be written in relative form if the manifest file is in a parent directory of the system file. I use enough-namestring for that in |
Sure, I'm glad I can help. |
I used the same variable names as the original code. |
Extend WRITE-ASDF-MANIFEST-FILE to consider local-projects systems.
Fixes #83
I tried to copy the same ideas of pathname handling and stream writing from other functions of the quicklisp-client package.
Maybe add to the docstring a tip saying to use
(ql:write-asdf-manifest-file)
and(ql:register-local-projects)
before using(ql:add-local-projects-to-manifest)
in order to keep all up-to-date?