Skip to content

Conversation

Maeeen
Copy link
Contributor

@Maeeen Maeeen commented Jun 19, 2025

This PR:

  • adds more exposed properties from Hyprland's IPC for toplevelsin HyprlandToplevel, e.g., whether the toplevel is urgent (not everything is present though)
  • bidrectional handles between an HyprlandToplevel and a Toplevel (Wayland)
  • adds a list of toplevels per workspaces, including whether they have an urgent toplevel or not

… and some testers.

Copy link
Member

@outfoxxed outfoxxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. In general avoid code directly after a }, and make sure you run the formatter.

@Maeeen
Copy link
Contributor Author

Maeeen commented Jun 20, 2025

I have applied the appropriate fixes (I believe.) Should be good now. Normally, just fmt and just lint-changed are okay with my changes

@Maeeen Maeeen requested a review from outfoxxed June 20, 2025 02:06
Copy link
Member

@outfoxxed outfoxxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple minor formatting nitpicks but it will be easier for me to just fix them when I merge it. Thanks!

@outfoxxed outfoxxed force-pushed the final branch 2 times, most recently from 3c530da to 5ccb89b Compare June 20, 2025 11:09
@outfoxxed outfoxxed merged commit e0457dd into quickshell-mirror:master Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants