Update CSS logo and add aria/improve accessibility #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the [new CSS Logo](https://github.com/CSS-Next/logo.css). This logo falls in line with the HTML, JS and TS logo's. This logo uses rebeccapurple and a design language to make clear that we're past the days of CSS3. [Click here for more information](https://github.com/CSS-Next/logo.css)
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GreenMan36
changed the title
Mathys-Gasnier
approved these changes
Dec 30, 2024
|
@GreenMan36, thank you very much for taking your time to improve the accessibility and the logo. Appreciate your work 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new CSS logo designed to better represent the language as a whole, rather than being tied specifically to version 3. The new logo uses elements inspired by community feedback and incorporates references to modern CSS features.
Additionally, I identified and resolved a few ARIA issues during the process to improve accessibility.
I just added the required role (image) and a text description to the SVG's used.
I also made sure the root element is considered presentation, this does not cascade but the framework adds a bunch of listeners including ones for interactions, causing accessibility errors to incorrectly show without this aria role.