Skip to content

Add Python snippets #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Add Python snippets #54

merged 8 commits into from
Dec 31, 2024

Conversation

Axorax
Copy link
Contributor

@Axorax Axorax commented Dec 31, 2024

Description

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link

netlify bot commented Dec 31, 2024

βœ… Deploy Preview for quicksnip ready!

Name Link
πŸ”¨ Latest commit 5d174d7
πŸ” Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/6773f06f31b77d0008a83757
😎 Deploy Preview https://deploy-preview-54--quicksnip.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Axorax
Copy link
Contributor Author

Axorax commented Dec 31, 2024

I split my PR into two PRs for the different languages.

Python one here
JavaScript one -> #51

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, take a look at my feedback and we can then move on !

@Mathys-Gasnier Mathys-Gasnier added update needed Code needs to be updated. Snippets labels Dec 31, 2024
@Axorax
Copy link
Contributor Author

Axorax commented Dec 31, 2024

I removed the faulty codes. Might revisit them later. Should be good for now.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Axorax
Copy link
Contributor Author

Axorax commented Dec 31, 2024

idk how this is a change but i hope it's okay...

image

@Mathys-Gasnier Mathys-Gasnier merged commit d6814c4 into quicksnip-dev:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Snippets update needed Code needs to be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants