Skip to content

Conversation

fiinnnn
Copy link
Contributor

@fiinnnn fiinnnn commented Aug 7, 2025

I noticed the backend plugin kept crashing on some queries.
The issue occurs when a field is missing from one or more documents, causing Float64() to be called on a null pointer.

This change adds a null check to prevent the panic.

@fmassot
Copy link
Contributor

fmassot commented Aug 7, 2025

Thank you @fiinnnn ! I will review by the end of the week and merge this.

Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fiinnnn for the PR. It would be nice to add a test.
I will merge it as is and add a test.

@fmassot fmassot merged commit ed4e6fa into quickwit-oss:main Aug 9, 2025
1 of 2 checks passed
fmassot added a commit that referenced this pull request Aug 9, 2025
@fiinnnn fiinnnn deleted the fix-float64-cast-panic branch August 12, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants