Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor editorial tweaks for s6.1. #321

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

seanturner
Copy link
Contributor

No description provided.

@seanturner seanturner added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Feb 17, 2017
@martinthomson
Copy link
Member

ugh, too many damned CAPITAL LETTERS in this doc.

@martinthomson martinthomson merged commit ee98dee into master Feb 17, 2017
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one revert

@@ -666,10 +666,10 @@ set and MUST include the new negotiated protocol version.
The client MUST set the VERSION flag and include its selected version on all
packets until it has 1-RTT keys and it has received a packet from the server
that does not have the VERSION flag set. With TLS, this means that unprotected
packets and 0-RTT protected packets all include a version field.
packets and 0-RTT protected packets all include a VERSION flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earlier form was actually more accurate. There's a VERSION flag that indicates (i) the presence of a version field in packets from client to server, and (ii) the packet is a version negotiation packet when the packet is server -> client.

@MikeBishop MikeBishop deleted the quic_trans-s6.1-editorial branch March 10, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants