Remove a MUST accidentally introduced by #3315 #3537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure I agree with it in all cases, and it's a new MUST, which makes #3315 inadvertently not editorial.
marten-seemann
approved these changes
Mar 22, 2020
|
We need to keep this, but we should ask for a consensus call. I'll open an issue. |
|
@martinthomson to produce some text here that separates retention policy (MUST) from signaling policy (SHOULD). |
martinthomson
added a commit
that referenced
this pull request
Apr 15, 2020
This explains what needs to be kept and why. Specifically, you need to keep ranges unless you have other means of ensuring that you don't accept packets from those ranges again. You also need to keep the largest acknowledged so that you can get a packet number from subsequent packets. This also recommends that ACK frames include the largest acknowledged always. That is primarily to ensure that ECN works properly, and even there, you only disable ECN if you get some weird reordering, so it's probably not a big deal if you don't follow this recommendation. Closes #3541. Closes #3537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I agree with it in all cases, and it's a new MUST, which makes #3315(Rewrite section on ack range limiting) inadvertently not editorial.
#3541 opened to discuss this issue.