More detail regarding dropping of ACK Ranges #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explains what needs to be kept and why. Specifically, you need to keep ranges unless you have other means of ensuring that you don't accept packets from those ranges again. You also need to keep the largest acknowledged so that you can get a packet number from subsequent packets. This also recommends that ACK frames include the largest acknowledged always. That is primarily to ensure that ECN works properly, and even there, you only disable ECN if you get some weird reordering, so it's probably not a big deal if you don't follow this recommendation. Closes #3541. Closes #3537.
martinthomson
added
editorial
marten-seemann
approved these changes
Apr 15, 2020
ianswett
approved these changes
Apr 18, 2020
|
@janaiyengar you should probably look at this. I have marked the associated issue |
janaiyengar
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains what needs to be kept and why. Specifically, you need to
keep ranges unless you have other means of ensuring that you don't
accept packets from those ranges again. You also need to keep the
largest acknowledged so that you can get a packet number from subsequent
packets.
This also recommends that ACK frames include the largest acknowledged
always. That is primarily to ensure that ECN works properly, and even
there, you only disable ECN if you get some weird reordering, so it's
probably not a big deal if you don't follow this recommendation.
The issue is marked design, but the resolution here is basically a restatement of other text. I think we can run this through the design process, but it isn't really worth flagging this in a change log in my opinion.
Closes #3541.
Closes #3537.