-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure short header section #4407
Conversation
5ea7d5d
to
fc3a207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The actual changes are much smaller than the diff appears, and I think the symmetry with 17.2 helps readability despite the extra layer.
Co-authored-by: Mike Bishop <mbishop@evequefou.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @janaiyengar. This LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I think we might want to make corresponding changes to the TLS draft.
Re TLS draft, I think we can replace all the occurrences of "short header packet(s)", "packet(s) with (a) short header" in the TLS draft with "1-RTT packet(s)", as well making necessary changes to table 1.
@kazuho: Thanks for the note. I've updated the tls doc, but I've left most uses of |
Fixes #4397.
This PR restructures 17.3 to be aligned with 17.2. Note that while the diff seems to show whole paragraphs changed in the
Spin Bit
section, all I've done is replaceda packet with a short header
witha 1-RTT packet
.Note that I've not replaced all uses of
short header
. I've retained it where it is used alongsidelong header
, for symmetry.This still touches more text than I had hoped, but it makes the structure of Section 17 clearer.