Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt tokio_timer::DelayQueue #64

Closed
Ralith opened this issue Oct 14, 2018 · 6 comments
Closed

Adopt tokio_timer::DelayQueue #64

Ralith opened this issue Oct 14, 2018 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ralith
Copy link
Collaborator

Ralith commented Oct 14, 2018

We're currently using an awkward heavyweight hack to schedule timers; see the quinn crate's EndpointInner struct's timer member for details. DelayQueue was literally purpose-built for our requirements, so let's put it to work.
@Ralith Ralith added enhancement New feature or request good first issue Good for newcomers labels Oct 14, 2018
@twilco twilco mentioned this issue Oct 17, 2018
Merged
@twilco
Copy link
Contributor

twilco commented Oct 17, 2018 •
edited

I'd like to take a go at this one. I'm busy the next couple days (will be at Rust Belt Rust!), and want to do some initial learning of Tokio as part of the Tokio docs push, but after that I will have time to work on this.

If someone else comes across this issue and feels motivated to take it before then let me know and we can work something out 👍.

@twilco
Copy link
Contributor

twilco commented Oct 24, 2018

Things have come up and I think I'm going to be busy for a bit, so if there's anyone else who wants to take this go for it.

@little-dude
Copy link

I'd like to work on that.

@Ralith
Copy link
Collaborator Author

Ralith commented Oct 28, 2018

Great! Feel free to hit up the gitter if you have any questions.

@little-dude
Copy link

So far so good, hopefully I'll submit a PR tonight or tomorrow :)

little-dude added a commit to little-dude/quinn that referenced this issue Oct 30, 2018
@little-dude
use a DelayQueue to manage InnerEndpoint's timers
1285bc2 
fixes quinn-rs#64
@little-dude little-dude mentioned this issue Oct 30, 2018
Closed
little-dude added a commit to little-dude/quinn that referenced this issue Oct 31, 2018
@little-dude
use a DelayQueue to manage InnerEndpoint's timers
910092a 
fixes quinn-rs#64
little-dude added a commit to little-dude/quinn that referenced this issue Nov 1, 2018
@little-dude
use a DelayQueue to manage InnerEndpoint's timers
e26e357 
fixes quinn-rs#64
@Ralith
Copy link
Collaborator Author

Ralith commented Mar 29, 2019

Mooted by #264

@Ralith Ralith closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ralith @twilco @little-dude