Reduce repetitive error handling (take two) #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
requested changes
Oct 16, 2018
twilco
force-pushed
the
reduce-repetitive-err-handling-take-two
branch
from
e5e2052
to
4bfadd0
Compare
twilco
commented
Oct 16, 2018
quinn-proto/src/endpoint.rs
Outdated
| } else { | ||
| State::closed(error_code) | ||
| } | ||
| }, |
There was a problem hiding this comment.
@Ralith - Maybe a better way to handle these repetitive if elses. I tried storing the error_code/reason in an Option and then doing a single if else below, but that didn't work for me.
If you have a good idea I'd love to hear it - otherwise I think this PR should be good to go.
twilco
force-pushed
the
reduce-repetitive-err-handling-take-two
branch
from
4bfadd0
to
1f2ff49
Compare
Ralith
requested changes
Oct 16, 2018
…nside handle_connected_inner, mostly in the way of event recording. This patch simplifies this by instead returning a Result, which allows the caller to handle either case and create events more succinctly than handle_connected_inner could. Also, this changeset moves the app_closed property from connection::State to connection::Connection itself, as it is much simpler to manage that piece of state on the Connection itself. Closes quinn-rs#51.
twilco
force-pushed
the
reduce-repetitive-err-handling-take-two
branch
from
1f2ff49
to
33cc759
Compare
|
@Ralith - Enumerated all |
|
+115/-204, very nice! Thanks for sticking with it! If you want to do more, we have a bunch more issues to chose from. 👍 |
|
Thank you both once again :). Sorry it was a bit of a slog. Learning more on each one! I have my eyes on #64, but have plans to do some reading up on Tokio first as part of the Tokio docs push. I'll leave a comment on the issue itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djc @Ralith
I managed to botch the rebase on my previous branch, so starting anew here.
Prior to this patch, we had duplicated lots of error handling logic inside
handle_connected_inner, mostly in the way of event recording. This patch simplifies this by instead returning aResult<State, ConnectionError>, which allows the caller to handle either case and create events more succinctly thanhandle_connected_innercould.Also, this changeset moves the
app_closedproperty fromconnection::Statetoconnection::Connectionitself, as it is much simpler to manage that piece of state on theConnectionitself.Closes #51.