Draft 17 recovery logic #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage ? 60.14%
=========================================
Files ? 21
Lines ? 5256
Branches ? 0
=========================================
Hits ? 3161
Misses ? 2095
Partials ? 0
Continue to review full report at Codecov.
|
Ralith
commented
Dec 24, 2018
djc
reviewed
Dec 24, 2018
Ralith
force-pushed
the
recovery-17
branch
2 times, most recently
from
28f7db0
to
90219f2
Compare
djc
previously approved these changes
Dec 25, 2018
|
Rebased. |
|
Rebased. Thanks for all the review work! |
djc
approved these changes
Dec 26, 2018
link2xt
added a commit
to link2xt/quinn
that referenced
this pull request
Nov 30, 2023
It is not used since <quinn-rs#134> (commit bdc9ac7) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.
link2xt
added a commit
to link2xt/quinn
that referenced
this pull request
Nov 30, 2023
It is not used since <quinn-rs#134> (commit bdc9ac7) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.
link2xt
added a commit
to link2xt/quinn
that referenced
this pull request
Nov 30, 2023
It is not used since <quinn-rs#134> (commit bdc9ac7) was merged in 2018. RFC 9002 also does not mention Tail Loss Probe except that it has been integrated into the PTO (Probe Timeout) mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much just went through and transcribed the new pseudocode, with minor adjustments along the same lines as the ones made previously. The logic is a little simpler and makes a little more sense this time around (e.g. no always-false bools).