fix: don't bail if setting IP_RECVTOS fails #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Nov 21, 2022
Ralith
requested changes
Nov 21, 2022
Ralith
reviewed
Nov 21, 2022
jfro
force-pushed
the
jtk/fix-macos-error
branch
from
108469b
to
ac469d9
Compare
|
Okay, can you please:
|
old macOS versions don't support it
jfro
force-pushed
the
jtk/fix-macos-error
branch
from
ac469d9
to
b3a9b5d
Compare
jfro
force-pushed
the
jtk/fix-macos-error
branch
from
b3a9b5d
to
56887a1
Compare
This was referenced Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old macOS versions don't have it, so if you try say
connectionexample on macOS 10.11, it'll error with IoError 42 - Protocol not available.I'm not sure if you're wanting a tracing log, or if you're planning on another 0.8.x release but we're still on it until we do our next non-bugfix release where we'll go to 0.9. Easily can be applied to 0.9/main too.