-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quinn-proto v0.10.0 w/ rustls v0.21.0 #1515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting on this!
Would be nice to squash most of these changes (except the one that seems like a technically unrelated bugfix), and also treat this branch/PR as the eventual upgrade PR (removing some of the test language from the PR title/description).
Also would be nice to include a separate commit that bumps the version number for quinn-proto to 0.10.0 (since we expose rustls publicly as part of our API, we need to do a semver-incompatible bump here if we make a semver-incompatible bump for rustls). The quinn crate already got one in #1502, so it doesn't need to be bumped.
25a1896
to
097835a
Compare
097835a
to
0ad878c
Compare
☑️ - Done.
☑️ - Done w/ 0ad878c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
0ad878c
to
e17beaa
Compare
I wanted to refresh this branch now that rustls/rustls#1216 was merged. I'm glad I did because it shook out a couple errors, now addressed in rustls/rustls#1236 I've switched the |
e17beaa
to
429380a
Compare
Fixed one more breaking change from upstream:
|
429380a
to
d79ed33
Compare
Now back to tracking |
d79ed33
to
b6b3cf4
Compare
This commit updates Quinn's dependency on Rustls from v0.20.3 to v0.21.0. This release includes a handful of small breaking changes which are resolved alongside the upgrade.
As part of upgrading the quinn-proto rustls dependency we must do a semver incompatible version bump since rustls is exposed as part of the public API.
b6b3cf4
to
75229c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Update branch for quinn-proto v0.10.0, using Rustls v0.21.0
deps: upgrade rustls v0.20.3 -> v0.21.0.
This commit updates Quinn's dependency on Rustls from v0.20.3 to v0.21.0.
This release includes a handful of small breaking changes which are resolved alongside the upgrade.
quinn-proto: bump version 0.9.2 -> 0.10.0.
As part of upgrading the quinn-proto rustls dependency we must do a semver incompatible version bump since rustls is exposed as part of the public API.
Blocking tasks