-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All: Rename package to QUnit #1232
Conversation
Seems good to me! I assume there will be another PR to https://github.com/qunitjs/qunitjs.com for the website itself? |
Yes. I'll have to change those names separately and add a notice about the versions and name compatibility. |
@qunitjs/qunit-team could I get a review from someone? Want to ensure at least one other maintainer is aware of these changes before proceeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only concern is publishing this as minor, feels like it should be semver-major. Happy to defer to team consensus though.
@platinumazure the version won't change. We have already released We can then deprecate Let me know if you still have concerns. |
Personally if this were my project I would still prefer to do a semver-major bump, but what you have outlined sounds reasonable as long as we have very good documentation on this point. No concerns from my side. |
Looks good to me. The important point to keep in mind, as we discussed on Gitter: The |
First step of fixing qunitjs/node-qunit#136.
After merging, I will manually do another 2.4.1 release under the
qunit
package name, so that users can migrate directly fromqunitjs@2.4.1
toqunit@2.4.1
. Then, we will deprecatequnitjs@2.4.1
with a message stating that users should switch to thequnit
package.All future releases will then be under the
qunit
name.As for the current
qunit
package, we will be switching that to be released asnode-qunit
. I've reached out to the owner of the currentnode-qunit
package (which is deprecated) and he is fine with us taking over the name.