Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Rename package to QUnit #1232

Merged
merged 1 commit into from
Nov 5, 2017
Merged

Conversation

trentmwillis
Copy link
Member

First step of fixing qunitjs/node-qunit#136.

After merging, I will manually do another 2.4.1 release under the qunit package name, so that users can migrate directly from qunitjs@2.4.1 to qunit@2.4.1. Then, we will deprecate qunitjs@2.4.1 with a message stating that users should switch to the qunit package.

All future releases will then be under the qunit name.

As for the current qunit package, we will be switching that to be released as node-qunit. I've reached out to the owner of the current node-qunit package (which is deprecated) and he is fine with us taking over the name.

@rwjblue
Copy link
Contributor

rwjblue commented Oct 23, 2017

Seems good to me! I assume there will be another PR to https://github.com/qunitjs/qunitjs.com for the website itself?

@trentmwillis
Copy link
Member Author

Yes. I'll have to change those names separately and add a notice about the versions and name compatibility.

@trentmwillis
Copy link
Member Author

@qunitjs/qunit-team could I get a review from someone? Want to ensure at least one other maintainer is aware of these changes before proceeding.

Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only concern is publishing this as minor, feels like it should be semver-major. Happy to defer to team consensus though.

@trentmwillis
Copy link
Member Author

@platinumazure the version won't change. We have already released qunitjs@2.4.1 and after merging this I will then publish qunit@2.4.1.

We can then deprecate qunitjs@2.4.1 on npm which will let users know that if they ever want to upgrade past 2.4.1 (completely opt-in) they will need to simply change qunitjs to qunit in their package.json. I think this is the cleanest upgrade path and saves us from bumping a major version when nothing is really changing in the implementation.

Let me know if you still have concerns.

@platinumazure
Copy link
Contributor

Personally if this were my project I would still prefer to do a semver-major bump, but what you have outlined sounds reasonable as long as we have very good documentation on this point. No concerns from my side.

@jzaefferer
Copy link
Member

Looks good to me. The important point to keep in mind, as we discussed on Gitter: The qunit package is currently at 1.0.0, so the new release 2.4.1 will require a major version bump for anyone currently using the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants