New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cursor follows playpack option #1809

Closed
D759 opened this Issue Feb 4, 2016 · 18 comments

Comments

Projects
None yet
5 participants
@D759

D759 commented Feb 4, 2016

it would be nice to have an option that the cursor follows the currently paying track.

Currently using QuodLibet on OS X 10.11

@lazka lazka added the needinfo label Feb 5, 2016

@lazka

This comment has been minimized.

Member

lazka commented Feb 5, 2016

Could you be more specific? Which cursor and which track do you mean?

@D759

This comment has been minimized.

D759 commented Feb 5, 2016

Sure.
When I doubleclick a song in the playlist view to play it, the line is marked blue (= "cursor") the playback indicator is the little play symbol on the left. Now when the song starts to play, the "cursor" stays where it was. (see attached screenshot: I clicked track 4 to play, playback moves to track 5, but the "cursor" stays on track 4)
I would like it to automatically jump the marking to the currently playing song.

(sorry if not clear, this is an option i am used to from foobar2000 where it is called "cursor follows playback")

bildschirmfoto 2016-02-05 um 19 04 10

@urielz

This comment has been minimized.

Contributor

urielz commented Feb 5, 2016

If this gets implemented it should be implement as an option in my opinion. At least in my case that is not the way I use the cursor. For example one I add a new album I often listen to it while I edit the metadata of songs, having the cursor jump to the current song being played would disrupt that process...

@lazka

This comment has been minimized.

Member

lazka commented Feb 5, 2016

@D759 I see, thanks. Why do you want that feature? Note that QL scrolls to the playing song when manually initiating a song change and provides a shortcut (ctrl+j) to jump to it.

I agree with @urielz that this can only be an option, if at all.

@D759

This comment has been minimized.

D759 commented Feb 5, 2016

I agree, it should definitely be an option (as it is in foobar)

The reason i want this feature is simply when I switch to QL (e.g. look at the song's name), the blue background is immediately visible, esp. compared to the play symbol, so I am a little confused everytime.

So it is just a minor incovenience.

@declension

This comment has been minimized.

Member

declension commented Feb 5, 2016

Sounds reasonable.... actually as a user this actually makes more sense to me than the current Follow Cursor plugin which does pretty much the opposite, but not for everyone.

Also calling it select current song might be more intuitive.

@lazka

This comment has been minimized.

Member

lazka commented Feb 6, 2016

So is it more a visual annoyance or do you want to move the selection with the current song?

Asking as an alternative could also be to remove the selection on song change if the selection was caused by "activating" a song by double click etc.

@D759

This comment has been minimized.

D759 commented Feb 6, 2016

Yes, it is a visual thing. The blue highlighting is simply the most clearly visible indicator.

To remove the selection on song change would at least prevent the "falsle" indication for me... But I still would find the (optional) highlighting of the playing song in the playlist visually the most appealing to me

@lazka

This comment has been minimized.

Member

lazka commented Feb 6, 2016

What about this?

screenshot from 2016-02-06 15-40-16

@D759

This comment has been minimized.

D759 commented Feb 7, 2016

Looks interesting... the light grey should catch less immediate attention than the blue highlighting

lazka added a commit that referenced this issue Feb 7, 2016

@lazka

This comment has been minimized.

Member

lazka commented Feb 7, 2016

It's an additional highlight of the current song. The selection color is still the same.

I've pushed it to master for now. Feedback welcome.. we can also remove it again.

@lazka lazka added discussion and removed needinfo labels Feb 7, 2016

@spxxxk

This comment has been minimized.

spxxxk commented Feb 7, 2016

I like the idea but it could look better on my dark theme. Current track is now white on light grey which is (a little bit) harder to read than the usual white on dark. Looks good on Ubuntu's Ambiance theme though.
Possibility to choose background color ? Maybe as an entry in the config file.

@lazka

This comment has been minimized.

Member

lazka commented Feb 7, 2016

Which theme?

@spxxxk

This comment has been minimized.

spxxxk commented Feb 7, 2016

Good question ! Made me remember I use an heavily hacked (by myself) Ambiance theme. So if it looks good on proper dark themes, ignore my comment .. That's my problem !

Attached screenshot of my theme.
ss

@lazka

This comment has been minimized.

Member

lazka commented Feb 7, 2016

ok, thanks, this is using ".entry:backdrop:insensitive {}" for the background color.

@urielz

This comment has been minimized.

Contributor

urielz commented Feb 8, 2016

Nice! Definitely looks better than the current look.

@D759

This comment has been minimized.

D759 commented Feb 8, 2016

I agree, it does look good!
The currently playing song is easily identifiable at first glance

@lazka

This comment has been minimized.

Member

lazka commented Feb 18, 2016

Removing the selection on activate is tricky as it needs some event hackery because GTK+ handles it internally, and I'm not sure if that's safe.

So I'm closing this for now. If needed we can add a plugin which makes the selection follow the playing song, shouldn't be too hard. Please post here or open a new issue if such a plugin is still wanted.

@lazka lazka closed this Feb 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment