Feat: Add support for the text_indopak_nastaleeq field. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK currently does not support the text_indopak_nastaleeq field. This field, instead of the text_indopak, is useful when the using the nastaleeq font as it correctly provides each verse's end characters.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Really sorry for the late reply, I totally forgot! The PR makes sense JAK, merging now. |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the
text_indopakfield the API doesn't return the surah ending characters correctly.Solution
Add support for the
text_indopak_nastaleeqfield that the API supports. This field, instead of the text_indopak, is useful when the using the nastaleeq font as it correctly provides each verse's end characters.Note
I've not introduce
text_indopak_nastaleeqfor theWordfields type. Looking at the API, I think that's not supported (which makes complete sense) and hence, I've just added it for the text field.