Only apply tafseer font to Arabic tafaseer #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, due to QuranUtils.doesStringContainArabic method returning true for languages like Urdu and others that share some of the Arabic characters in the ranges that were checked, an Arabic font was set for any such language. This consequently broke many non-Arabic RTL languages on versions above 21. This patch fixes it by only applying the font to Arabic tafaseer, while still gracefully handling RTL otherwise. Fixes #1255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to QuranUtils.doesStringContainArabic method returning
true for languages like Urdu and others that share some of the Arabic
characters in the ranges that were checked, an Arabic font was set for
any such language. This consequently broke many non-Arabic RTL languages
on versions above 21.
This patch fixes it by only applying the font to Arabic tafaseer, while
still gracefully handling RTL otherwise. Fixes #1255.